fix: use the same signature when implementing BenchLike#541
Merged
Conversation
commit: |
size-limit report 📦
|
BenchLike
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Bench’s signal property declaration to match the BenchLike interface under exactOptionalPropertyTypes, avoiding invalid “optional vs | undefined” signature mismatches for downstream consumers (e.g., Vitest builds with that compiler option enabled).
Changes:
- Change
Bench.signalfromAbortSignal | undefinedto an optional propertysignal?: AbortSignalto correctly implementBenchLike.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@sheremet-va: I will do a patch release with that API fix ASAP. |
Member
Author
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
exactOptionalPropertyTypes, it's not valid to defineval: Value | undefinedwhen implementingval?: Valueinterface:https://github.com/vitest-dev/vitest/actions/runs/24994604053/job/73188302056?pr=10113
Error: ../../../../node_modules/.pnpm/tinybench@6.0.0/node_modules/tinybench/dist/index.d.ts(629,15): error TS2420: Class 'Bench' incorrectly implements interface 'BenchLike'. Types of property 'signal' are incompatible. Type 'AbortSignal | undefined' is not assignable to type 'AbortSignal'. Type 'undefined' is not assignable to type 'AbortSignal'.