fix: replace plimit with own promises limiter implementation to plug mem leak #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ avoid memory leak + trigger the GC less often closes tinylibs#365 Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
commit: |
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Uzlopak
reviewed
Nov 2, 2025
Uzlopak
reviewed
Nov 2, 2025
Uzlopak
reviewed
Nov 2, 2025
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
Signed-off-by: Jérôme Benoit <jerome.benoit@piment-noir.org>
- Standardize naming to pattern: [prefix-technique] [core-functionality] [(async/sync)] - Convert verbose descriptions to concise technical format - Update 32 test descriptions across 8 files for consistency - Improve code readability and maintainability - All tests continue to pass (104 passing, 1 skipped)
Collaborator
Author
|
The current approach keeping the p-limit 'stream' API is inherently racy at task abortion handling. |
43081j
reviewed
Nov 3, 2025
43081j
reviewed
Nov 3, 2025
jerome-benoit
commented
Nov 6, 2025
with less time it should be less flaky
jerome-benoit
commented
Nov 7, 2025
jerome-benoit
commented
Nov 8, 2025
jerome-benoit
commented
Nov 8, 2025
jerome-benoit
commented
Nov 8, 2025
jerome-benoit
commented
Nov 8, 2025
jerome-benoit
commented
Nov 8, 2025
src/utils.ts
Outdated
| } | ||
|
|
||
| const worker = async () => { | ||
| while (!finished) { |
Collaborator
Author
There was a problem hiding this comment.
the caller is blocked until there's a room to proceed the next. I think it's fine for tinybench usage and avoid the usage of intermediate mechanism to store internally the work left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #365