small fix replacing download_file with fetch#10877
Merged
chenyuxyz merged 3 commits intotinygrad:masterfrom Jun 19, 2025
Merged
small fix replacing download_file with fetch#10877chenyuxyz merged 3 commits intotinygrad:masterfrom
chenyuxyz merged 3 commits intotinygrad:masterfrom
Conversation
chenyuxyz
reviewed
Jun 19, 2025
examples/so_vits_svc.py
Outdated
| @@ -20,7 +20,7 @@ | |||
| F0_MEL_MAX = 1127 * np.log(1 + F0_MAX / 700) | |||
|
|
|||
| def download_if_not_present(file_path: Path, url: str): | |||
Collaborator
There was a problem hiding this comment.
remove this function and just use fetch?
Contributor
Author
There was a problem hiding this comment.
yes, made those changes in the latest commit.
Contributor
|
This branch currently is behind tinygrad/master. The line count difference bot is disabled. |
4359157 to
458cf83
Compare
chenyuxyz
reviewed
Jun 19, 2025
examples/so_vits_svc.py
Outdated
| @classmethod | ||
| def load_from_pretrained(cls, checkpoint_path:str, checkpoint_url:str) -> ContentVec: | ||
| download_if_not_present(checkpoint_path, checkpoint_url) | ||
| if not os.path.isfile(checkpoint_path): fetch(checkpoint_url, checkpoint_path) |
Collaborator
There was a problem hiding this comment.
still need if not os.path.isfile?
Contributor
Author
There was a problem hiding this comment.
you are right. sorry for rushing. removed those
Collaborator
|
have you tested this from a fresh env so made sure it works? also please update pr title |
Contributor
Author
yes, fetch works for me.
updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i added os as it was missing and replaced download file with fetch from helpers