Add enough tls.ConnectionState and tls.CipherSuiteName() to compile fortio/log#4345
Merged
deadprogram merged 2 commits intotinygo-org:devfrom Jul 20, 2024
Merged
Add enough tls.ConnectionState and tls.CipherSuiteName() to compile fortio/log#4345deadprogram merged 2 commits intotinygo-org:devfrom
deadprogram merged 2 commits intotinygo-org:devfrom
Conversation
ydnar
reviewed
Jul 18, 2024
src/crypto/tls/common.go
Outdated
| // TINYGO: empty; TLS connection offloaded to device | ||
| // TINYGO: empty; TLS connection offloaded to device [?] | ||
| // | ||
| // Minimum (empty) fields for fortio.org/log http logging to |
Contributor
There was a problem hiding this comment.
What is the broader implication? net/http compatibility?
Contributor
Author
There was a problem hiding this comment.
well... if I ever get a super simple server working with tinygo, it'd have the logging I use elsewhere for servers... I haven't tried others but mine does need these fields even empty to compile
edit: the wip test is https://github.com/ldemailly/go-scratch/blob/main/tinyhttp/tinyhttp.go
Contributor
Author
There was a problem hiding this comment.
in short it's incremental progress - can we merge?
dgryski
reviewed
Jul 19, 2024
Contributor
Author
|
@deadprogram thanks for having merged the other, what about this one :) cheers |
Contributor
Author
|
(just rebased) |
Member
|
Thanks for the addition @ldemailly and to @dgryski for review. Now merging. |
Contributor
Author
|
thx! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that net/http is broken on macOS but this allows it to work on Linux (and waspi)
edit: linux also doesn't work #4346