Allows compilation of code using debug.BuildInfo and show correct tinygo version by ldemailly · Pull Request #4343 · tinygo-org/tinygo

ldemailly · 2024-07-16T23:49:08Z

That let's me build a 245k tinygo target grol-io/grol#37
(also needed some change in fortio.org/log)

Many thanks to @ydnar and @dankegel for their help and guidance.

…ygo version

dkegel-fastly

LGTM

src/runtime/debug/debug.go

ydnar · 2024-07-17T00:39:27Z

src/runtime/debug/debug.go

+//
+// Not implemented.
+func (bi *BuildInfo) String() string {
+	return "<build info placeholder>\n"


Can you implement this?

given everything else is empty in the struct, what would that do?

could we just import the real code from big go?

"else"? It's not printing anything at all. It could at least return "go. " + GoVersion, couldn't it?

ic the first line sure, I didn't notice because when I use buildinfo I print the GoVersion separately let me add something

btw should it be

go tinygo0.33.1

or

tinygo tinygo0.33.1

doing the former, copying the code

@dkegel-fastly so I copied the real code but... it's ugly... what is the general philosophy/must not be the first time tinygo is just a small variant of an existing go file, can you import+patch or some other way to avoid copy pasta (this is more for my education than anything specific for this PR - hopefully it's ok now with 41dd04a )

ldemailly · 2024-07-17T01:02:59Z

output comparison (through fortio.org/version) - edited for latest commit:

$ ./grol.tiny buildinfo
dev  tinygo0.33.0-dev arm64 darwin
go	tinygo0.33.0-dev
$ ./grol buildinfo
dev  go1.22.5 arm64 darwin
go	go1.22.5
path	grol.io/grol
mod	grol.io/grol	(devel)	
dep	fortio.org/cli	v1.7.0	h1:w+uXZLGi4t3Vn/BvbeMuSw84Z1pvNPG9HqeGfpP68cc=
dep	fortio.org/log	v1.15.0-pre4	h1:jAr6cn7AHhKBBdD6M2WlCqNWnePyCMp9A6++o0Zl0jY=
dep	fortio.org/struct2env	v0.4.1	h1:rJludAMO5eBvpWplWEQNqoVDFZr4RWMQX7RUapgZyc0=
dep	fortio.org/version	v1.0.4	h1:FWUMpJ+hVTNc4RhvvOJzb0xesrlRmG/a+D6bjbQ4+5U=
dep	github.com/kortschak/goroutine	v1.1.2	h1:lhllcCuERxMIK5cYr8yohZZScL1na+JM5JYPRclWjck=
build	-buildmode=exe
build	-compiler=gc
build	-tags=no_net,no_json
build	-trimpath=true
build	CGO_ENABLED=0
build	GOARCH=arm64
build	GOOS=darwin
build	vcs=git
build	vcs.revision=9396c9b051e054a7783f75195aac0084f20911d2
build	vcs.time=2024-07-16T07:02:48Z
build	vcs.modified=true

ydnar · 2024-07-17T17:52:46Z

src/runtime/debug/debug.go

@@ -1,6 +1,13 @@
 // Package debug is a dummy package that is not yet implemented.


Should this comment be removed?

it's still kinda dummy - I was wondering about the comment

// Not implemented. func ReadBuildInfo()

and figured to leave it as it's... only giving an empty one (no modules, no settings etc) except for GoVersion

ldemailly · 2024-07-18T02:03:06Z

I see the approvals, thanks, would one of you merge, I can't (wouldn't anyway)

dkegel-fastly · 2024-07-18T03:43:39Z

src/runtime/debug/debug.go

 	return n
 }
+
+// Start of stolen from big go. TODO: import/reuse without copy pasta.


I do believe a copyright notice should be copied here...?

isn’t this covered by https://github.com/tinygo-org/tinygo/blob/release/LICENSE#L3 ?

I think the copyright folks like to have a greppable marker in each file.

I like the way runtime/timer.go does it: copy the three top llines from the file you're copying, and change "Copyright" to "Portions copyright".

Thanks, I was looking for an example, thanks for mentioning src/runtime/timer.go

Done

ldemailly · 2024-07-18T17:30:31Z

~~hmm I messed up my fork trying to start a new PR earlier (about TLS) let me fix this (hopefully)~~ fixed PTAL

ldemailly · 2024-07-18T19:49:50Z

The previous build https://github.com/tinygo-org/tinygo/actions/runs/9977696304 of size difference, before llvm18 got broken, passed, so can we merge this ? (only difference is the comment at the top of the file, since that build)

ldemailly · 2024-07-19T01:38:50Z

ping

deadprogram · 2024-07-20T10:49:18Z

@ldemailly please rebase against the latest dev and this PR should pass CI now.

deadprogram · 2024-07-20T13:25:44Z

Actually, I can just squash/merge this now, I think.

Thank you very much @ldemailly for working on this and to @ydnar and @dkegel-fastly for guidance and reviews.

Allows compilation of code using debug.BuildInfo and show correct tin…

11ffebb

…ygo version

dkegel-fastly approved these changes Jul 17, 2024

View reviewed changes

ydnar reviewed Jul 17, 2024

View reviewed changes

ldemailly mentioned this pull request Jul 17, 2024

tinygo support, goroutine hack change, fix panic for invalid stderr, add test fortio/log#66

Merged

review comment, use the runtime.Compiler constant

1d4f0e7

copying the actual code of the stringer from big go

41dd04a

ydnar approved these changes Jul 17, 2024

View reviewed changes

ydnar reviewed Jul 17, 2024

View reviewed changes

dkegel-fastly reviewed Jul 18, 2024

View reviewed changes

review comment: added (c) header inspired from runtime/timer.go

f90b5c1

ldemailly force-pushed the dev branch from df2a3fb to f90b5c1 Compare July 18, 2024 17:35

deadprogram merged commit 89340f8 into tinygo-org:dev Jul 20, 2024

		@@ -1,6 +1,13 @@
		// Package debug is a dummy package that is not yet implemented.

Uh oh!

Conversation

ldemailly commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkegel-fastly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Jul 18, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Jul 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldemailly commented Jul 18, 2024

Uh oh!

ldemailly commented Jul 19, 2024

Uh oh!

deadprogram commented Jul 20, 2024

Uh oh!

deadprogram commented Jul 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ldemailly commented Jul 16, 2024 •

edited

Loading

ldemailly commented Jul 17, 2024 •

edited

Loading

ldemailly commented Jul 18, 2024 •

edited

Loading