builder: update configuration to support Arch Linux LLVM 13 installation#2498
Merged
deadprogram merged 2 commits intotinygo-org:devfrom Jan 9, 2022
Merged
builder: update configuration to support Arch Linux LLVM 13 installation#2498deadprogram merged 2 commits intotinygo-org:devfrom
deadprogram merged 2 commits intotinygo-org:devfrom
Conversation
Member
|
The CI fail should be fixed by a rebase against |
Member
|
I already changed the base branch for this PR to |
Arch Linux has turned on the stack protector by default. This causes a crash in libc init because the stack protector uses TLS before it is initialized.
Arch Linux stores the clang executable seperately from its data, so the search based on the executable does not work. This change searches /usr/lib as a backup.
Member
Author
|
Ugh, macos just seems to be timing out repeatedly. |
Member
|
I think I will merge anyway, and see if the Thanks @niaow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes two changes which make TinyGo work with the default installed LLVM/clang on Arch:
-fno-stack-protectorto musl - it is on by default on Arch, which causes TLS to be used before initialization