Skip to content

Add option to use rustls 0.20.#212

Closed
ghost wants to merge 2 commits into
masterfrom
unknown repository
Closed

Add option to use rustls 0.20.#212
ghost wants to merge 2 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 1, 2021

Copy link
Copy Markdown

This a minor update of #155 to use the latest version of rustls.
I think this is useful because it allows tiny-http to serve TLS on platforms that don't have OpenSSL, like OpenBSD.

@bradfier

Copy link
Copy Markdown
Member

This is excellent and something I very much want to support, apologies for leaving the PR to stagnate, it seems I wasn't getting email notifications for this repo.

Could you rebase onto master and fix the build failures then I'll re-review?

@travispaul

travispaul commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

Hi there @bradfier and @3xmblzj5,

I've rebased @3xmblzj5`s branch (and updated the examples and cert/key) here: https://github.com/travispaul-forks/tiny-http/tree/rustls20

Would you like me to open a separate PR? I too would like this feature! I also have a fork of rouille where this appears to be working after a quick smoketest and some minor changes: travispaul-forks/rouille@4d264b9

@bradfier

bradfier commented Feb 5, 2022

Copy link
Copy Markdown
Member

Hi there @bradfier and @3xmblzj5,

I've rebased @3xmblzj5`s branch (and updated the examples and cert/key) here: https://github.com/travispaul-forks/tiny-http/tree/rustls20

Would you like me to open a separate PR? I too would like this feature! I also have a fork of rouille where this appears to be working after a quick smoketest and some minor changes: travispaul-forks/rouille@4d264b9

Please do @travispaul! I'm currently casting an eye over your branch at rustls20 and I have a couple of comments already, but it would be great if you opened a PR here so we can discuss them conveniently.

When you've done so I can close this PR and redirect visitors to the new one.

@travispaul travispaul mentioned this pull request Feb 5, 2022
@travispaul

travispaul commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

@bradfier I've created /pull/218 please add any comments or suggestions and I'll work on them.

Any obvious build/test failures I will work on Monday (along with comments if there are any by that time.)

Thanks and have a great weekend!

@ghost

ghost commented Feb 12, 2022

Copy link
Copy Markdown
Author

Closing this as work on this is being carried on in another PR.

@ghost ghost closed this Feb 12, 2022
@ghost ghost deleted the rustls20 branch February 12, 2022 18:28
@ghost ghost restored the rustls20 branch February 12, 2022 18:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants