This repository was archived by the owner on Dec 2, 2025. It is now read-only.
Merged
Conversation
Signed-off-by: Micah Hausler <mhausler@amazon.com>
ScottGarman
approved these changes
Jan 19, 2022
Contributor
Author
|
Pretty sure I'll have to merge this manually once github lets me. |
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
==========================================
+ Coverage 34.76% 36.01% +1.24%
==========================================
Files 44 44
Lines 3348 3207 -141
==========================================
- Hits 1164 1155 -9
+ Misses 2085 1959 -126
+ Partials 99 93 -6
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop go from shell.nix (for now) and use the system's go binary.
Why is this needed
CI is currently breaking because of conflicting go versions.
The better fix would be cutting over fully to nix in CI or reverting this commit once actions/setup-go#175 is merged and released.
How Has This Been Tested?
CI
How are existing users impacted? What migration steps/scripts do we need?
CI isn't broken and PRs can be merged.