Remove logging functionality and drop bunyan dependency.#85
Merged
timkindberg merged 2 commits intotimkindberg:masterfrom Sep 19, 2021
Merged
Conversation
Owner
|
Let's just remove it |
Contributor
Author
|
Updated! |
Contributor
Author
|
Thanks for accepting my PR! This is a great library, and does exactly what I needed. 😄 |
Owner
|
Hey thanks for the kind words and the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37.
Generally seems like bunyan has trouble building on people's machines for reasons that I cannot understand, but given the minor role the logger plays it seems overkill to bring in such a fully-featured logger.I subbed it out withdiary, which is super fast, tiny, and does the trick. It creates a scoped logger, which is silent by default, unless you choose to listen to it:If we wanted to move forward with these changes, it'd be worth mentioning the functionality in the README.But honestly, I think it'd be better to drop the logger entirely. It's not a feature people know about, and I'm not convinced it's worth keeping a logger around anyway. It just adds another dependency, and I'm not sure anyone would use it.
If @timkindberg agrees, I can completely pull out the logger code so this library stays as slim as possible.
[EDIT]
Based off discussion, changing this PR to fully remove logging functionality and dependencies.