feat(): make jest an peer dependancy#84
Merged
timkindberg merged 3 commits intotimkindberg:masterfrom Sep 19, 2021
Merged
Conversation
Owner
|
Ok so even with the separate concern of importing equals from jasmineUtils you think this is safe to merge as a non-breaking minor release? |
Contributor
Author
|
Yes, In my opinion it should safe but can run this patch tomorrow on large codebase at work. We use jest-when in few hundred tests. |
Contributor
Author
|
I run on one of our codebases, it has 97 imports of jest-when, all tests passed and possibly slightly faster. |
|
It's a minor data point but I run the tests for ericcornelissen/svgo-action successfully when using these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address #81. I tested with jest 24, 25, 26 and 27, it should work with other versions as well. This could be released as non-breaking change. My concern is that his still imports jesmineUtils from private module api see https://github.com/facebook/jest/blob/d6e5ddb0c3c1af54f443f225aa14cdf07c7bb593/packages/expect/package.json#L12
I think we should raise issue on jest repo to expose equals in public API of expect package.