Arm32: Fix crashes due to long handling#1297
Merged
cevian merged 3 commits intotimescale:masterfrom Jun 14, 2019
Merged
Conversation
JLockerman
approved these changes
Jun 13, 2019
Contributor
JLockerman
left a comment
There was a problem hiding this comment.
Approved, but my approval doesn't mean much, I helped write it 😉
Fix 64 bit constants to be correctly defined, and some other logic issues so that the timer logic works correctly under arm32
Go through the code and verify that no L constants need to be defined as INT64CONST. Add comments as appropriate.
Remove ignored tests that are now passing.
svenklemm
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.