feat: support pg13, pg14 as pgvector does#94
Merged
syvb merged 10 commits intotimescale:mainfrom Oct 3, 2024
Merged
Conversation
This PR try to support pg12-pg14 as pgvector supports. some of the codes from zombodb close: timescale#93 Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: zombodb <zombodb@gmail.com>
|
|
Collaborator
|
@yihong0618 thanks. I'll review this. |
|
👋 Just 👍 this PR as having the same version support as pgvector would be very helpful for our use cases, we primarily use pg14 right now. |
Contributor
|
Could you remove PG12 support? I don't think it's worth it to add complexity for a PG version that will be obsolete in 2 months. |
Contributor
Author
OK wil do it these days |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Contributor
Author
syvb
reviewed
Oct 2, 2024
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: Matvey Arye <cevian@gmail.com>
cevian
approved these changes
Oct 3, 2024
Collaborator
cevian
left a comment
There was a problem hiding this comment.
Thanks so much for this change
syvb
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR try to support pg12-pg14 as pgvector supports. some of the codes from zombodb
close: #93