fix: buildempty() should write init fork#89
Merged
tjgreen42 merged 3 commits intotimescale:mainfrom Dec 28, 2025
Merged
Conversation
tjgreen42
reviewed
Dec 24, 2025
Collaborator
tjgreen42
left a comment
There was a problem hiding this comment.
This looks like a nice catch. What would a test case for this look like?
Collaborator
Author
I added a regression test that:
I think the file name |
tjgreen42
approved these changes
Dec 28, 2025
Collaborator
tjgreen42
left a comment
There was a problem hiding this comment.
Cool, thanks for the unit test. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An index's
buildempty()should modify the init fork, not the main fork. This commit replacesReadBuffer()withReadBufferExtended(index, INIT_FORKNUM, P_NEW, RBM_NORMAL, NULL)to fix the issueHere is how to verify the bug using commit 2031307:
You can see that the init fork is empty, i.e., does not contain a meta page