Remove dead Python validation dependencies#295
Conversation
scripts/requirements.txt referenced rank-bm25, pandas, numpy, scipy, and other packages used by bm25_validation.py and validate_all_tests.py. Those Python scripts were deleted previously but requirements.txt and the README documenting them were left behind. Nothing in CI or benchmarks uses these dependencies.
There was a problem hiding this comment.
LGTM — straightforward removal of orphaned documentation and Python dependencies for scripts that were already deleted.
Extended reasoning...
Overview
This PR deletes scripts/requirements.txt (6 lines of Python package pins) and trims scripts/README.md from 54 lines down to 5, removing documentation for bm25_validation.py and validate_all_tests.py which no longer exist.
Security risks
None. Removing unused dependency declarations and dead documentation carries no security implications.
Level of scrutiny
Minimal. This is a pure cleanup of leftover artifacts from a prior deletion commit. The diff is entirely subtractive — no new code, logic, or configuration is introduced.
Other factors
The PR description confirms grep -r requirements.txt shows no remaining references and CI workflows are unaffected. No bugs were reported by the automated review system.
Summary
scripts/requirements.txt(rank-bm25, pandas, numpy, scipy, etc.)scripts/README.mdto document only the remainingpackage-deb.shThe Python validation scripts (
bm25_validation.py,validate_all_tests.py) were deleted previously but theirrequirements.txtand README documentation were left behind. Nothing in CI or benchmarks references these dependencies.Testing
grep -r requirements.txtconfirms no remaining referencesscripts/requirements.txt)