Conversation
Update version from 1.0.0-dev to 0.6.1 across all files: - pg_textsearch.control, mod.c, CLAUDE.md, README.md - Rename SQL files and upgrade scripts - Add upgrade path from 0.6.0 to 0.6.1
All 55 expected output files reference the version in the prerelease warning emitted by CREATE EXTENSION.
There was a problem hiding this comment.
LGTM — mechanical version bump from 1.0.0-dev to 0.6.1 across SQL, C, config, and test expected output files.
Extended reasoning...
Overview
This PR bumps the version from 1.0.0-dev to 0.6.1 across 64 files: pg_textsearch.control, src/mod.c, CLAUDE.md, README.md, Makefile, 4 SQL upgrade/install scripts, and 55 test expected output files. All changes are mechanical find-and-replace of the version string 1.0.0-dev → 0.6.1 (or corresponding filename changes). The 0.6.0--0.6.1 upgrade script also adds a comment describing the bugfix.
Security risks
None. This PR contains no logic changes — only version string replacements in metadata files, SQL version checks, and test expected output. No auth, crypto, or permission code is touched.
Level of scrutiny
Low scrutiny warranted. This is a purely mechanical version bump. The SQL upgrade scripts contain version-check guards that are copy-paste consistent across all four files. The test expected output changes are all identical single-line replacements of the WARNING message. The inline bug report about the missed image rename and benchmark script version string is valid but cosmetic — neither affects functionality.
Other factors
- CI validates all regression tests, sanitizers, and upgrade paths per the PR description.
- The inline nit about
README.mdline 19 still referencingtapir_and_friends_v1.0.0-dev.pngandrun_v2_benchmark.shline 66 checking for1.0.0-devis confirmed accurate, but both are non-functional issues (the image still renders because the file exists, and the benchmark just emits a spurious warning). - No CODEOWNERS file is present in the repo.
| - Best in class performance and scalability | ||
|
|
||
| 🚧 **Development**: v1.0.0-dev - Working toward GA. See [ROADMAP.md](ROADMAP.md) for details. | ||
| 🚧 **Development**: v0.6.1 - Working toward GA. See [ROADMAP.md](ROADMAP.md) for details. |
There was a problem hiding this comment.
🟡 Incomplete version bump: README.md line 19 still references images/tapir_and_friends_v1.0.0-dev.png (should be v0.6.1.png per RELEASING.md step 4), and benchmarks/datasets/msmarco-v2/run_v2_benchmark.sh line 66 still checks for version "1.0.0-dev", which will now always emit a spurious warning. Neither breaks functionality, but both are missed steps in the version bump.
Extended reasoning...
Image reference not updated in README.md
The PR correctly updates the version text on README.md line 17 from v1.0.0-dev to v0.6.1, but line 19 still references images/tapir_and_friends_v1.0.0-dev.png. The project's own RELEASING.md checklist explicitly requires two actions in step 4:
- Rename the image file:
git mv images/tapir_and_friends_vX.Y.Z-dev.png images/tapir_and_friends_vX.Y.Z.png - Update the image reference in README.md
Neither was done. The image still renders correctly because the old file tapir_and_friends_v1.0.0-dev.png still exists, but this is inconsistent with the release checklist and with the pattern established by all prior releases (v0.1.0 through v0.5.0 each had properly named images).
Benchmark script version check not updated
The file benchmarks/datasets/msmarco-v2/run_v2_benchmark.sh has a check_tapir_version() function at line 66 that compares the installed extension version against a hardcoded string "1.0.0-dev". Before this PR, the version was 1.0.0-dev so the check passed. After this PR bumps the version to 0.6.1, running the benchmark will always produce:
WARNING: Expected 1.0.0-dev, got 0.6.1
The benchmark itself still runs correctly since this is only a warning, but it's a spurious diagnostic that could confuse users.
Step-by-step proof
- README.md line 17 was changed from
v1.0.0-devtov0.6.1(visible in the diff) - README.md line 19 still reads
(confirmed by reading the file) - RELEASING.md lines 51-57 explicitly instruct to rename the image and update the reference
run_v2_benchmark.shline 66 checksif [ "$ver" != "1.0.0-dev" ]— after this PR,$verwill be0.6.1, so the condition is always true
Fix
For the image: git mv images/tapir_and_friends_v1.0.0-dev.png images/tapir_and_friends_v0.6.1.png and update README.md line 19 accordingly. For the benchmark script: change "1.0.0-dev" to "0.6.1" on line 66 of run_v2_benchmark.sh.
Summary
Testing