fix: crash when creating BM25 index on temp table#248
Merged
Conversation
FlushOneBuffer() asserts !BufferIsLocal(buffer), which fails for temporary tables whose buffers are backend-local. Guard every FlushOneBuffer call with !BufferIsLocal() to skip the flush for temp relations. This is safe because temp data is not WAL-logged and doesn't need crash-recovery durability. Adds temp_table regression test covering the savepoint-rollback and full-rollback crash scenarios from the bug report.
6e8ec09 to
ae1c221
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247.
Summary
FlushOneBuffer()asserts!BufferIsLocal(buffer), which fails for temporary tables whose buffers are backend-localFlushOneBuffercall with!BufferIsLocal()to skip the flush for temp relationsThe fix covers 7 call sites across
src/am/build.c(3) andsrc/state/metapage.c(4).FlushRelationBuffers()calls in the segment code already handle local buffers correctly.Testing
temp_tableregression test covering:ROLLBACK TO SAVEPOINTafter BM25 scan (original crash from BM25 index scan inside a transaction that is rolled back crashes the PostgreSQL server #247)ROLLBACKafter BM25 scan (second crash case from BM25 index scan inside a transaction that is rolled back crashes the PostgreSQL server #247)CREATE INDEXitself via savepointON COMMIT DROPtemp table with BM25 index