feat: detect stale binary after upgrade via library version check#241
Merged
feat: detect stale binary after upgrade via library version check#241
Conversation
Add a pg_textsearch.library_version GUC (PGC_INTERNAL) set at library load time, and check it in CREATE EXTENSION / ALTER EXTENSION UPDATE SQL scripts. This catches the case where a user installs a new binary but forgets to restart the server, preventing shared memory layout mismatches or silent behavior differences.
Use pg_catalog.current_setting and OPERATOR(pg_catalog.<>) to satisfy pgspot's unqualified reference checks (PS016, PS001).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_textsearch.library_versionread-only GUC set at library load time from a compile-time version defineCREATE EXTENSIONandALTER EXTENSION UPDATESQL scripts, failing with a clear error if the loaded library is missing or doesn't match the expected versionmake installbut forgets to restart the serverChanges
EXTVERSIONfrompg_textsearch.control, pass as-DPG_TEXTSEARCH_VERSIONPGC_INTERNALstring GUC in_PG_initTesting
SHOW pg_textsearch.library_versionreturns1.0.0-devafter restart