fix: resolve test failures on PG17 and /tmp environments#234
Merged
Conversation
Three fixes for tests that fail locally but pass on CI: 1. binary_io: Switch COPY to \copy (client-side) so temp files are owned by the test runner, avoiding /tmp sticky-bit permission issues when the PG server creates files as a different user. 2. coverage: Use a shared temp directory with 777 permissions for server-side file writes (pageviz, dump). Add id tiebreaker to queries with tied BM25 scores for deterministic row ordering. 3. inheritance: Extend is_child_partition_index() to handle regular table inheritance. PG17's planner may choose a child table's index over the parent's; the validation hook now allows this when the tables have an inheritance relationship.
dfec168 to
0e09439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COPYto\copy(client-side) so temp files are owned by the test runner user, avoiding/tmpsticky-bit permission issuesidtiebreaker to queries with tied BM25 scores for deterministic orderingis_child_partition_index()inhooks.cto handle regular table inheritance — PG17's planner may choose a child table's index over the parent'sTest plan
make format-checkpasses