Skip to content

fix: resolve test failures on PG17 and /tmp environments#234

Merged
tjgreen42 merged 1 commit intomainfrom
fix/local-test-failures
Feb 19, 2026
Merged

fix: resolve test failures on PG17 and /tmp environments#234
tjgreen42 merged 1 commit intomainfrom
fix/local-test-failures

Conversation

@tjgreen42
Copy link
Copy Markdown
Collaborator

@tjgreen42 tjgreen42 commented Feb 19, 2026

Summary

  • binary_io: Switch COPY to \copy (client-side) so temp files are owned by the test runner user, avoiding /tmp sticky-bit permission issues
  • coverage: Use shared temp dir with 777 permissions for server-side file writes; add id tiebreaker to queries with tied BM25 scores for deterministic ordering
  • inheritance: Extend is_child_partition_index() in hooks.c to handle regular table inheritance — PG17's planner may choose a child table's index over the parent's

Test plan

  • All 47 SQL regression tests pass locally on PG17
  • make format-check passes
  • CI passes (PG17, PG18, sanitizer builds)
  • Verify inheritance test still passes on PG18 (planner behavior differs)

Three fixes for tests that fail locally but pass on CI:

1. binary_io: Switch COPY to \copy (client-side) so temp files are
   owned by the test runner, avoiding /tmp sticky-bit permission
   issues when the PG server creates files as a different user.

2. coverage: Use a shared temp directory with 777 permissions for
   server-side file writes (pageviz, dump). Add id tiebreaker to
   queries with tied BM25 scores for deterministic row ordering.

3. inheritance: Extend is_child_partition_index() to handle regular
   table inheritance. PG17's planner may choose a child table's
   index over the parent's; the validation hook now allows this
   when the tables have an inheritance relationship.
@tjgreen42 tjgreen42 force-pushed the fix/local-test-failures branch from dfec168 to 0e09439 Compare February 19, 2026 21:55
@tjgreen42 tjgreen42 merged commit fc9553c into main Feb 19, 2026
15 checks passed
@tjgreen42 tjgreen42 deleted the fix/local-test-failures branch February 19, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant