bench: add VACUUM step to ParadeDB benchmarks for segment compaction#233
Merged
bench: add VACUUM step to ParadeDB benchmarks for segment compaction#233
Conversation
ParadeDB merges index segments during VACUUM, so running VACUUM after CREATE INDEX ensures the index is fully compacted before querying. Without this, we may be benchmarking ParadeDB in a suboptimal state. The VACUUM time is included in the reported index_build_time_ms via an INDEX_VACUUM: marker that extract_metrics.sh sums with CREATE INDEX time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VACUUMafterCREATE INDEXin ParadeDB (System X) MS MARCO v1 and v2 load scripts to trigger segment compactionindex_build_time_msmetric via anINDEX_VACUUM:marker parsed byextract_metrics.shParadeDB merges index segments during VACUUM, so without this step we may be benchmarking it in a suboptimal state with uncompacted segments.
Testing