bench: add MS MARCO v2 dataset and weighted-average latency metric#226
Merged
bench: add MS MARCO v2 dataset and weighted-average latency metric#226
Conversation
Add benchmark infrastructure for the MS MARCO v2 passage ranking dataset (138M passages) with download, load, query, and System X comparison scripts. Introduce weighted-average query latency as a new tracked metric across all benchmark datasets (MS MARCO v1, v2, Wikipedia). Per-bucket p50 latencies are weighted by the observed MS-MARCO v1 lexeme distribution (1M queries: 3-token mode at 30%, mean 3.7 tokens) to produce a single summary number that reflects realistic workload performance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a separate weighted throughput output line (weighted avg ms/query using the MS-MARCO v1 lexeme distribution) alongside the existing weighted latency. Update extract_metrics.sh and format_for_action.sh to extract and report the new metric. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files changed
New (MS MARCO v2 benchmark infrastructure):
benchmarks/datasets/msmarco-v2/— download, load, query scripts + benchmark queries TSVbenchmarks/datasets/msmarco-v2/systemx/— System X (ParadeDB) comparison scriptsModified (weighted-average metric):
benchmarks/datasets/msmarco/queries.sql— add weighted-average computationbenchmarks/datasets/wikipedia/queries.sql— add weighted-average computationbenchmarks/runner/extract_metrics.sh— extractWEIGHTED_LATENCY_RESULTfrom logsbenchmarks/runner/format_for_action.sh— report weighted latency in github-action-benchmark formatbenchmarks/runner/run_benchmark.sh— add msmarco-v2 as a dataset optionbenchmarks/gh-pages/methodology.html— document weighted methodology + MS MARCO v2 datasetDistribution weights (MS-MARCO v1, 1,010,905 queries)
Test plan
WEIGHTED_LATENCY_RESULTappears in outputextract_metrics.shon output and verify JSON includesweighted_latencysectionformat_for_action.shand verify "Weighted Latency" appears in action output🤖 Generated with Claude Code