Implement AMPROP_DISTANCE_ORDERABLE in amproperty#133
Merged
Conversation
Add tp_property() function to report the distance_orderable property for BM25 index columns. This allows pg_index_column_has_property() to correctly return true instead of NULL for the 'distance_orderable' property. Fixes #103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ampropertycallback lets access methods report capabilities that Postgres can't infer automatically. For properties likedistance_orderable, Postgres returns NULL if the access method doesn't implement the callback.Since BM25 indexes support ORDER BY via the
<@>operator, we should reportdistance_orderable = true. This improves reporting of index capabilities through tools like pgAdmin.Fixes #103
Testing
All existing regression tests pass.