Conversation
7a1e917 to
ce7fa1b
Compare
Address all 11 issues reported by Coverity scan: High severity: - merge.c: Initialize dict_buf to InvalidBuffer (CID 640953, 640947) Medium severity: - build.c: Add NULL check before tp_calculate_idf_sum (CID 640951) - am/scan.c: Add early return if scan opaque is NULL (CID 640946) - am/scan.c: Add NULL check after scoring query (CID 640955) - memtable/scan.c: Add early return if scan opaque is NULL (CID 640949) - segment/scan.c: Add NULL check for reader parameter (CID 640952) - state.c: Remove redundant NULL check (CID 640954) - state.c: Fix continue in PG_CATCH using flag pattern (CID 640957) - merge.c: Add explicit NULL check in allocation condition (CID 640950) - segment.c: Remove dead code in num_blocks calculation (CID 640956) - merge.c: Remove dead code in num_blocks calculation (CID 640948)
ce7fa1b to
b3db29b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all 11 Coverity static analysis issues reported in the initial scan.
Issues Fixed
dict_bufInvalidBuffertp_insertTesting