blog article #03: Visualizing Nginx Access Logs using Timeplus and Grafana#798
Conversation
jovezhong
left a comment
There was a problem hiding this comment.
Good start. I reckon this PR is working-in-progress. Please add more content with screenshots. Look forwards to the final PR
f57c1ee to
e136df8
Compare
jovezhong
left a comment
There was a problem hiding this comment.
I shared some comments. Please make the PR as draft PR, as it's not complete yet. I am on travel these 2 weeks so may not provide timely review. Once the PR is ready to review, I will spend more time on this.
54811ec to
f6714ce
Compare
f6714ce to
91d401a
Compare
|
Hi @jovezhong! I've addressed all of your review comments. This PR is ready for review so hopefully you'll be able to take a look soon. I hope you are enjoying your travels |
|
Thank you. I will share my feedback in 48 hours, if not sooner. |
jovezhong
left a comment
There was a problem hiding this comment.
Again @ayewo , this is a very nice blog with huge potential. Not just for ppl who wants to learn more about streaming processing, for network engineers or anyone who wants to learn more about nginx, network traffic monitoring, or SQL for O11y, this will be a great hit.
I shared my comments. It will great to change the background of the code snippet from blue to dark color as our blog. But this can be time consuming and you can do this later or don't have to do it.
As a reader, I am very excited to see this big dashboard. But the blog ends right here, which is a bit disappointing.
Maybe you can add a few screenshot to explain each panel to highlight why it's helpful to understand the data pattern.
You can also show the SQL behind.
If you can use streaming SQL, then maybe this can be a live dashboard to show the current traffic. In that case, a GIF will be very impressive.
Please also add a short section to summarize the blog and highlight some takeaways.
examples/nginx-grafana/README.md
Outdated
| Before I dive into the article proper, I will first revisit the format used by Nginx to record access log data so that the data we'll generate will mimic its shape and properties. | ||
|
|
||
| ## The Shape of Nginx's Access Log Data | ||
| In the [previous article](https://www.timeplus.com/post/analyzing-nginx-access-logs), we briefly touched on the Nginx access logs but did not dwell on its location or how the data it contains should be parsed. |
There was a problem hiding this comment.
"its location". I am a bit surprised to see "location". Do you mean how this is generated or data is parsed?
There was a problem hiding this comment.
Location in this context meant where the Nginx access logs is stored on disk. I've reworded it.
|
|
||
| The first line in the access log is from the IP address `161.35.230.x`. | ||
|
|
||
|  |
There was a problem hiding this comment.
Thanks for the nice screenshots. I guess you may use tools like https://carbon.sh/ to generate it with background. However since your blog will be posted on timeplus.com with dark background. It will be great if you can use that dark color #0F0D10 to replace the blue background. You may have to change the text color too. Sorry for the trouble
There was a problem hiding this comment.
I hear you.
Yes, I used Carbon and thought that the background I picked would work well with the T+ blog.
I used the Preview.app on macOS which meant creating each one took a lot of time. Maybe I'll find time to recreate them but it shouldn't prevent you from approving this, if there are no other blockers.
|
|
||
| ### Random Streams | ||
| There is an important note about the design of random streams in Timeplus Proton mentioned in the [`RANDOM STREAM`](https://docs.timeplus.com/proton-create-stream#create-random-stream) documentation that is worth highlighting here: | ||
| > [!NOTE] |
There was a problem hiding this comment.
I realized there could be a misunderstanding based on my previous doc, that people may think all data generated will be kept in the memory. I changed that doc to the following text. Please quote it or highlight it in your own words
When you run a Timeplus SQL query with a random stream, the data will be generated and analayzed by the query engine. Depending on the query, all generated data or aggregated states can be kept in memory during the query time. If you are not querying the random stream, there is no data generated or kept in memory.
There was a problem hiding this comment.
It's still there. Perhaps you updated a different page?
On https://docs.timeplus.com/proton-create-stream#create-random-stream when I do a Ctrl+F for this text:
The data of random stream is kept in memory during the query time. If you are not querying the random stream, there is no data generated or kept in memory.
There was a problem hiding this comment.
I will publish that doc change in 1 or 2 hours. Same link
|
All feedback addressed! |
jovezhong
left a comment
There was a problem hiding this comment.
Thanks for the nice blog. Approved (better to change the title to add Timeplus)
|
/tip 225 |
|
🎉🎈 @ayewo has been awarded $225! 🎈🎊 |
PR checklist:
proton: starts/endsfor new code in existing community code base ? N?APlease write user-readable short description of the changes: