Conversation
nlemoine
approved these changes
Nov 24, 2022
Member
Author
|
I also want to get a final approval from @jarednova on this one. |
jarednova
approved these changes
Jan 7, 2023
Member
jarednova
left a comment
There was a problem hiding this comment.
This looks great. Continues the theme of opening up for other libs that do things like (get/post/request objects) much better!
Member
Author
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #2631 (comment)
Issue
As discussed in #2631 (comment), the
Timber\Requestclass provides very limited functionality.Solution
Remove the
Timber\Requestclass and add a path to upgrade to a more advanced solution in the Upgrade Guide.Impact
Yes, this is breaking.
Usage Changes
Described in the Upgrade Guide.
Considerations
None.
Testing
None.