Update upgrade guide to reflect new image API#2341
Merged
gchtr merged 4 commits into2.x-docs-apifrom Oct 18, 2020
Merged
Conversation
Actual implementation to be done in #2333
Collaborator
Author
|
see also: #2342 |
# Conflicts: # docs/v2/upgrade-guides/2.0.md
gchtr
approved these changes
Oct 18, 2020
Member
gchtr
left a comment
There was a problem hiding this comment.
This looks good. I fixed a small issue, because there never was a TimberImage() method on Timber\Post.
And then I realized the introductory wording for the updated Twig methods was off, too.
With all the changes coming in from the factories branch, I think it’s best I recheck the whole Upgrade Guide again, because updates were scattered in pull request against 2.x and against 2.x-docs-api.
I’ll do that separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actual implementation to be done in #2333
Just some updates about the image/posts API that surfaced in #2316.