Skip to content

2316/deprecate term getter#2322

Merged
jarednova merged 5 commits into2.x-factoriesfrom
2316/deprecate_term_getter
Sep 14, 2020
Merged

2316/deprecate term getter#2322
jarednova merged 5 commits into2.x-factoriesfrom
2316/deprecate_term_getter

Conversation

@jarednova
Copy link
Copy Markdown
Member

Deprecate the TermGetter class

@jarednova jarednova marked this pull request as ready for review September 12, 2020 17:29
@jarednova
Copy link
Copy Markdown
Member Author

I think this is ready for a quick look @acobster or @gchtr. There is one failing test related to PostQuery being used in Timber::context(); ...

1) TestTimberContext::testPostsContextSimple
Unexpected deprecated notice for Timber\PostQuery::get_posts()
Failed asserting that an array is empty.

/srv/www/wordpress-trunk/public_html/tests/phpunit/includes/abstract-testcase.php:494
/srv/www/timber/tests/Timber_UnitTestCase.php:17
/srv/www/wordpress-trunk/public_html/tests/phpunit/includes/abstract-testcase.php:506

... but this isn't connected to the code here and I believe is addressed in #2316

@acobster
Copy link
Copy Markdown
Collaborator

@jarednova looks good to me (and you're correct about that PostQuery usage), although I was kinda planning on deleting this class (among others) as part of THE PURGE. 🔪 It's not documented AFAIK and will break expectations set in the docs if it's used. If you see a good reason to keep it around as deprecated, I suppose I can stay my bloodlust.

@jarednova
Copy link
Copy Markdown
Member Author

@acobster cool! let's take up the question of deprecation vs. blood over on #2323

@jarednova jarednova merged commit d8fbbd5 into 2.x-factories Sep 14, 2020
@jarednova jarednova deleted the 2316/deprecate_term_getter branch September 14, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants