#2301 Keep Twig native filter parity#2314
Merged
jarednova merged 2 commits intotimber:masterfrom Aug 25, 2020
Merged
Conversation
Member
|
This is great, thanks for the tweak @nlemoine ! I'll merge and tag as a new release later today so you can start using asap |
Member
Author
|
🙏 Thanks a lot for the quick merge @jarednova! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2301
Issue
The recent changes made in #2301 triggered many errors in my templates (
array_filterrunning onPostCollectionobject). I usefiltera lot and I use it againstPostCollectionwhich isn't an array.Solution
Implement the native
twig_array_filtermethod: https://github.com/twigphp/Twig/blob/1fb577363d3e3b5ce1b737b3255f2491b5f80833/src/Extension/CoreExtension.php#L1588-L1593Impact
It shouldn't because that method was used before that change.
Usage Changes
None.