Merged
Conversation
Member
|
Made a few small changes — back to you for merging! |
Member
Author
|
@jarednova Cool, thanks for your improvements! I’ll merge this in then and then work on the documentation about the pages menu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #2089
Issue
There are some improvements that we can make to the Menu Class Maps.
Solution
According to what was proposed in #2089
WP_Term) instead of a$locationstring.$locationparameter from the Menu Item Class Map, because that is already present through$menu->theme_location.Impact
None.
Usage Changes
None.
Considerations
-
Testing
No.