Ticket: #2169

This pull request adds on top of #2169. But because I had to change more than I thought, this comes in a separate pull request so we can discuss it first.

In 302e08b, you changed the order the posts were created. This go me thinking. If we want to check for the oldest post and make sure we ignore the post ID, which is an indicator of the order the posts were created in, then the post expect to be returned shouldn’t be the first to be created.

In 58d24dd, you changed the parameter in the test to any, which is not the same as an array of post types. Because of this, a different function to search for posts was used, making the tests pass. I think we should check for both.

I figured out that post_exists() and get_page_by_title() won’t work if we go for the oldest post and don’t want to sort by ID. That’s why I replaced post_exists() and get_page_by_title() with our own query in d6f95d3. I usually try to avoid creating direct queries, but I think there’s no easier way to search for a post title.

But by doing that, we open a new possibility to make the function more useful. We could add order arguments:

public static function get_post_by( $type, $search_value, $args = [] ) {
    $args = wp_parse_args( $args, [
        'post_type' => 'any',
        'order_by'  => 'post_date',
        'order'     => 'ASC'
    ]

    // ...
}

This way, developers could decide on their own to change the logic a post is selected when there are multiple posts available.