2.x User factories DocBlocks#2168
Merged
acobster merged 4 commits into2.x-user-factoriesfrom Jan 17, 2020
Merged
Conversation
jarednova
approved these changes
Jan 12, 2020
| * Gets one or more users as an array. | ||
| * | ||
| * By default, Timber will use the `Timber\User` class to create a your post objects. To | ||
| * control which class is used for your post objects, use [Class Maps](). |
Member
There was a problem hiding this comment.
This is the one thing I was like, "oh, we should remember to make a guide/link for that" and then I saw you were one step ahead of me with yr @todo
Codecov Report
@@ Coverage Diff @@
## 2.x-user-factories #2168 +/- ##
=====================================================
Coverage ? 94.25%
Complexity ? 1607
=====================================================
Files ? 53
Lines ? 4094
Branches ? 0
=====================================================
Hits ? 3859
Misses ? 235
Partials ? 0
Continue to review full report at Codecov.
|
acobster
approved these changes
Jan 17, 2020
Collaborator
acobster
left a comment
There was a problem hiding this comment.
These look great. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #2160
This pull request improves the DocBlocks for the new User API and the User Class Map, so that they will properly appear in the online documentation.