Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x-docs-api #2167 +/- ##
==================================================
+ Coverage 95.72% 96.03% +0.31%
- Complexity 1539 1576 +37
==================================================
Files 50 50
Lines 3949 4063 +114
==================================================
+ Hits 3780 3902 +122
+ Misses 169 161 -8
Continue to review full report at Codecov.
|
jarednova
reviewed
Jan 12, 2020
Member
jarednova
left a comment
There was a problem hiding this comment.
Both of these read great to me. The rundown on Class Maps really helps make everything click with the big benefits to the API changes. The only pending Q is on whether null or false is the correct return over on #2160. Pending the outcome of that, this should match
update documented return value from `null` to `false` Co-Authored-By: Jared Novack <jarednova@upstatement.com>
Collaborator
|
@jarednova I committed your suggestions, merging this in now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #2160 (comment)
Issue
We already have new guides for Posts and Terms in #2073. We should have one for Users as well.
Solution
Add Users Guide and clarify working with User Class Maps.
Impact
None.
Usage Changes
None.
Considerations
None?
Testing
None needed.