Provide notice for min. WordPress version#2156
Merged
Conversation
acobster
requested changes
Jan 8, 2020
gchtr
previously approved these changes
Jan 8, 2020
Codecov Report
@@ Coverage Diff @@
## 2.x #2156 +/- ##
=====================================
Coverage ? 95.6%
Complexity ? 1531
=====================================
Files ? 50
Lines ? 3933
Branches ? 0
=====================================
Hits ? 3760
Misses ? 173
Partials ? 0
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #2151
Issue
As discussed in #2135, we're dropping support for WordPress versions prior to 5.3 in 2.x. To do this, we need to let people know.
Solution
Let 'em know! Through the upgrade guide, ensuring the
require-devin composer is correct (we can't do comments/annotations in here, but this is one way to indicate) and an admin notice in case someone is running a WP version that's older than 5.3.Once inside of the
Adminclass I realized we could get rid of the bulk of what's here since it modifies the plug-in entry for Timber (which we're also not supporting in 2.x, in favor of Composer/Packagist only)Impact
This helps let devs know to upgrade their WordPress.
Considerations
We could copy over some of this code into 1.x (perhaps upon the last release to WP.org) to let people know that there won't be any further plugin support and to upgrade to both WP 5.3+ and Timber 2.x+ for new sites