Add found_posts property to Timber\PostQuery#2074
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2074 +/- ##
============================================
+ Coverage 95.01% 95.02% +<.01%
- Complexity 1572 1574 +2
============================================
Files 49 49
Lines 3714 3718 +4
============================================
+ Hits 3529 3533 +4
Misses 185 185
Continue to review full report at Codecov.
|
Member
|
Let's see, we got
... yeah, I want to do something to feel useful — but I think it's all taken care of by @gchtr. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #1973, #1257
Issue
There is no easy way to access the amount of found posts in a query.
Solution
Add
found_postsproperty toTimber\PostQuery. It will only be filled ifTimber\PostQueryusesTimber\QueryIteratorinternally, but not when what you pass toTimber\PostQueryis already a collection of posts.Impact
Happyness.
Usage Changes
You can now access the amount of found posts through the
found_postsproperty inTimber\PostQuery:Considerations
Are there other properties that should be easy to access?
Testing
Yes. Including tests for special cases when
no_found_rowsis used in the query.