Removed almost empty methods#1790
Merged
gchtr merged 1 commit into2.x-context-revisionfrom Sep 19, 2018
Merged
Conversation
gchtr
approved these changes
Sep 19, 2018
Member
gchtr
left a comment
There was a problem hiding this comment.
The separate functions made sense, when they had more logic inside them. But with the reduced logic, they are probably superfluous.
Your change makes the code much more readable 😎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gchtr I removed the two almost empty methods in the
Timberclass