Hey @gchtr, thanks as always for the PR and tests. I'm wondering if the {{ item.target }} approach you had suggested in #1629 might be a more universal solution though. The Twig result would be...

Item targets can now be checked with

<a href="{{ item.link }}" target="{{ item.target }}">

And in combination with MenuItem::is_external():

<a href="{{ item.link }}" {{ item.target is '_blank' or item.is_external ? 'target="_blank"' }}>

I realize it's a small distinction, but it seems (slightly) more versatile. While I agree with @gserafini that the possibilities are pretty limited, this would eliminate the need for a conditional in menus (only requiring it if someone wanted the external or blank logic). What say you?

@jarednova The only reason I didn’t choose to use target="{{ item.target }}" is that target="_self" would be an obsolete attribute. I also thought about having

<a href="{{ item.link }}" {{ item.target }}>

which could add target="_blank" if necessary, but throughout Timber, we only ever add the value of an attribute, and not a whole attribute (right ?). And I didn’t think about reducing conditionals in menus, which is a really good reason. So yeah, I see, we should probably go with:

<a href="{{ item.link }}" target="{{ item.target }}">

But why don’t we add both? Would we add redundancy if developers could still use item.is_target_blank()?

<a href="{{ item.link }}" {{ item.is_target_blank or item.is_external ? 'target="_blank"' }}>

And I see, before we merge this, I should probably update the menu guides and add target="{{ item.target }} where necessary.

I'm good with both! (and the gif that goes along with it). Let's do it