build: don't stat directories that we don't plan to upload#5768
Merged
Conversation
7304c29 to
157ed50
Compare
Member
Author
|
I'm hoping the upstream patches will be accepted, because they're pretty minimal/non-invasive (which you can see in the vendor diff). But figure we'll have to patch anyway because we're on an older version of buildkit. |
Contributor
FWIW if the fork(s) become onerous to maintain, we could probably get most of the way there by using the existing |
milas
approved these changes
May 5, 2022
Member
Author
|
ya, it's tricky because ExcludePatterns MUST be relative to the context, so would need to do a fair bit of re-formatting |
creates some temporary patches on buildkit until we can upstream them fixes #5745
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @milas, @landism,
Please review the following commits I made in branch nicks/walk:
c1a8373 (2022-05-04 19:06:56 -0400)
build: don't stat directories that we don't plan to upload
creates some temporary patches on buildkit until we can upstream them
fixes #5745
Code review reminders, by giving a LGTM you attest that: