build: Trick buildkit into not reading .dockerignore#5416
Merged
Conversation
Member
Author
|
v excited about the comment-to-code ratio in this PR tbh |
landism
approved these changes
Jan 28, 2022
Comment on lines
+552
to
+554
| // server-side. There's a little dance Buildkit does to determine whether to | ||
| // grab my.Dockerfile.dockerignore from the dockerfile dir, or whether to grab | ||
| // .dockerignore from the context dir. |
Member
There was a problem hiding this comment.
if you have a link handy where you read about this dance (code or issue or whatever), that might be good to add here
Member
Author
There was a problem hiding this comment.
not off the top of my head, sorry! i think i might have gotten this from talking to the docker folks
Member
Even with this warning, the comment exceeded expectations! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @landism,
Please review the following commits I made in branch nicks/ignore:
5b4dd90 (2022-01-27 17:54:10 -0500)
build: Trick buildkit into not reading .dockerignore
Fixes #5415
Code review reminders, by giving a LGTM you attest that: