Conversation
|
👍 |
| @@ -1 +1,72 @@ | |||
| kind,scalerank | |||
| kind,operator,zoom::int,area::int,scalerank | |||
| national_park;park or protected land;battlefield,!United States Forest Service,3,>=300000000,1 | |||
There was a problem hiding this comment.
park or protected landis an outmoded v0.10 reference, it should be removed I think?- Make sure
!United States Forest Servicematches Olga's change from last week?
|
Looks like this is written more for tier than What about adding an additional column for In the stylesheet it would be nice to be able to filter generically on |
CSVMatcher now uses the header key to determine if the column is an output column - those with the prefix "output:" are used. This allows the use of multiple outputs in the same CSV, and that is used to output both the scalerank and tier from the landuse CSV.
|
@rmarianski I've changed the code somewhat to allow CSVs to have multiple output columns. Please could you take a look and let me know what you think? @nvkelso Please look at the test and let me know if that's what you wanted from |
|
👍 |
… clearer. Also removed unnecessary 'sys' import left over from debugging.
| # for the first row where all the matchers return true. | ||
| target_vals = {} | ||
|
|
||
| for i in range(0, len(row)): |
There was a problem hiding this comment.
range defaults to 0, but is this equivalent?
for (is_target, key, typ), val in zip(row, cols):There was a problem hiding this comment.
Yes! That's much better, thanks. Fixed in 1cf7672.
… tier is broken out as a separate item.
|
Tests are looking good. But one question, what is the 2nd test on vector-datasource/integration-test/473-landuse-scalerank.py Lines 13 to 18 in 57aeb9c tier and scalerank?
That US National Forest thing is definitely not a |
|
Debug (colors, filters) Tangram file: Prettified (same as debug but with pretty colors) Tangram file: |
Adds a property representing the "tier" from #473; an integer from 1-6.
Connects to #473.
@rmarianski could you review, please?