Skip to content

Disputed feature documentation#2085

Merged
jeffdefacto merged 8 commits intomasterfrom
disputed_feature_documentation
May 24, 2022
Merged

Disputed feature documentation#2085
jeffdefacto merged 8 commits intomasterfrom
disputed_feature_documentation

Conversation

@jeffdefacto
Copy link
Copy Markdown
Contributor

This adds scripts and documentation needed to utilize our disputed border work.

@jeffdefacto jeffdefacto requested a review from nvkelso May 24, 2022 21:00
Comment thread docs/disputed-features.md Outdated

## Disputed capitals

Some cities are considered different administrative levels depending on a country's viewpoint. One country may consider a city to be a regional or country capital while a disputant does not. Natural Earth has this information in the `ne_10m_admin_1_label_points_details` table for affected countries in the `FCLASS_XX` columns. Using Wikidata tags, the NE `FCLASS_XX` data is joined to the OSM feature to create output kinds of `regional_capital:xx` or `country_capital:xx` with a true or false value to allow for different rendering options.
Copy link
Copy Markdown
Member

@nvkelso nvkelso May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the populated places Natural Earth theme instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Wikidata ID tags (add ID)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you're right. updated

Comment thread docs/disputed-features.md Outdated
Comment thread scripts/disputed_relation_overpass_query.txt Outdated

[out:xml][timeout:25];
(
rel(9520114); // Extent of Moroccan Claim at Melilla
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How brittle is this? How does someone know to add a new relation (and which one) to this list?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question we don't have a great answer to at the moment.

In general, the answer is when NE updates, adds, or removes a relation, then this list should follow. No one else (so far) is making disputed relations in quite the same way as us so it will presumably be an active decision to create a new one on our part rather than locate an existing one.

Copy link
Copy Markdown
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address a few nits. Otherwise very easy to follow, great documentation!

@jeffdefacto jeffdefacto merged commit 034ac5f into master May 24, 2022
@jeffdefacto jeffdefacto deleted the disputed_feature_documentation branch May 24, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants