more rigorous countries labels per ISO and point-of-view#2069
Merged
jeffdefacto merged 66 commits intomasterfrom May 24, 2022
Merged
more rigorous countries labels per ISO and point-of-view#2069jeffdefacto merged 66 commits intomasterfrom
jeffdefacto merged 66 commits intomasterfrom
Conversation
nvkelso
reviewed
Apr 20, 2022
Member
…with matching NE features (#2082)
for more information, see https://pre-commit.ci
…for-new-POVs' into junderwood/hide_non_ne_countries
for more information, see https://pre-commit.ci
…' into junderwood/hide_non_ne_countries
…for-new-POVs' into junderwood/hide_non_ne_countries
for more information, see https://pre-commit.ci
…' into junderwood/hide_non_ne_countries
nvkelso
reviewed
May 19, 2022
Member
nvkelso
left a comment
There was a problem hiding this comment.
Please list out which labels this suppresses (as unrecognized) and which labels it adds or otherwise changes.
nvkelso
reviewed
May 20, 2022
Member
|
Please also list out in the PR description the country labels this adds (eg made changes in OSM / patches / LUA / SQL). |
nvkelso
reviewed
May 21, 2022
Member
|
Please ensure that all the countries are listed here, otherwise they'll come out "unrecognized" in high zooms for RAWR: Because of: Specifically:
|
nvkelso
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds sql to alter the tlc table to edit the featurecla column to mark certain geounits as country or unrecognized. OSM labels that match with unrecognized countries or are a non match will return as kind=unrecognized at min zoom 8.
Countries updated as unrecognized
Countries updated to Admin-0 dependency
Newly rendering countries from data, lua, and sql improvements