Estimate population for null pop OSM places#1993
Closed
Conversation
Member
Author
|
Over to @travisgrigsby to take this over the finish line. |
ccbd3bb to
cd0b8f3
Compare
OSM data is very messy for these
Useful Overpas query:
```
/*
This has been generated by the overpass-turbo wizard.
The original search was:
“place=town and population=*”
*/
[out:json][timeout:250];
// gather results
(
// query part for: “place=town and population=*”
node["place"="city"]["population"](if:t["population"]<5000)({{bbox}});
way["place"="city"]["population"](if:t["population"]<5000)({{bbox}});
relation["place"="city"]["population"](if:t["population"]<5000)({{bbox}});
node["place"="town"]["population"](if:t["population"]<5000)({{bbox}});
way["place"="town"]["population"](if:t["population"]<5000)({{bbox}});
relation["place"="town"]["population"](if:t["population"]<5000)({{bbox}});
);
// print results
out body;
>;
out skel qt;
```
Member
Author
|
Please also update the newly failing tests:
|
nvkelso
commented
Nov 17, 2021
Member
Author
nvkelso
left a comment
There was a problem hiding this comment.
The logic and new tests look good.
Please fix the other 2 related tests and then ready to merge.
tgrigsby-sc
approved these changes
Nov 17, 2021
Contributor
tgrigsby-sc
left a comment
There was a problem hiding this comment.
We still need to clean up the unstyledLocalities tests
…ace-pop-estimates
Member
Author
|
Closed in favor of #2013. |
This was referenced Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1992
Break out filters in landuse.yaml for different localities by whether they have a population listed or not. If they don't, make the min_zoom higher and estimate the population.