Skip to content

[tests] POI direction calculation#1921

Merged
nvkelso merged 10 commits intomasterfrom
nvkelso/add-direction-POI-tests
Aug 12, 2019
Merged

[tests] POI direction calculation#1921
nvkelso merged 10 commits intomasterfrom
nvkelso/add-direction-POI-tests

Conversation

@nvkelso
Copy link
Copy Markdown
Member

@nvkelso nvkelso commented Aug 9, 2019

Connects with #598 to add tests for earlier PR.

  • Update tests
  • Update docs

@nvkelso nvkelso changed the title WIP: [tests] POI direction calculation [tests] POI direction calculation Aug 10, 2019
@nvkelso nvkelso requested review from iandees and rmarianski August 10, 2019 00:34
@nvkelso
Copy link
Copy Markdown
Member Author

nvkelso commented Aug 10, 2019

@iandees @rmarianski I added tests and docs for the new direction property added in #1916 and added a few guards against bad data. Please have a 👀.

Comment thread vectordatasource/transform.py Outdated
@nvkelso nvkelso merged commit deebbc8 into master Aug 12, 2019
@nvkelso nvkelso deleted the nvkelso/add-direction-POI-tests branch August 12, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants