Hide early gardens, allotments, university#1742
Conversation
… POI type (was already landuse).
| # allotments | ||
| - filter: | ||
| landuse: allotments | ||
| min_zoom: 16 |
There was a problem hiding this comment.
Gardens and allotments are similar, should they range a little in zoom, and exclude the private, no access ones?
not: { access: [ "private", "no" ] } min_zoom: { min: [ { max: [ 16, { col: zoom }, *tier6_min_zoom ] }, 17 ] }
(They are different keys – landuse, leisure, so probably makes sense to keep separate blocks. Fine to keep a-z sorted in the YAML.)
- Example of larger allotments at zoom 16: https://www.openstreetmap.org/way/209279018#map=16/38.8516/-77.1020
- Medium sized at zoom 17: https://www.openstreetmap.org/way/257182338#map=17/37.71556/-122.42809
- You already have a point example in tests.
| # university | ||
| - filter: {amenity: university} | ||
| min_zoom: { min: [ { max: [ { sum: [ { col: zoom }, 2.55 ] }, *tier3_min_zoom ] }, 15 ] } | ||
| min_zoom: { min: [ { max: [ { sum: [ { col: zoom }, 2.55 ] }, *tier3_min_zoom ] }, 16 ] } |
There was a problem hiding this comment.
Just noting for review that college was already set to default min_zoom: 16 so no action was needed there.
| z, x, y, 'pois', { | ||
| 'id': 32055218, | ||
| 'kind': u'allotments', | ||
| 'min_zoom': 16, |
There was a problem hiding this comment.
Should be large enough test to see it show up in zoom 16. No action needed, as long as the given area is large enough to generate 16 on it's own with proposed changes in min_zoom calculation above.
nvkelso
left a comment
There was a problem hiding this comment.
Minor change about allotment min_zoom, otherwise LGTM.
nvkelso
left a comment
There was a problem hiding this comment.
Please also adjust the garden default (no area) min_zoom to 17 from 16.
nvkelso
left a comment
There was a problem hiding this comment.
All changes made, ready to merge.
Hide early point (no area) gardens, universities. Add allotments as a POI type (was already landuse).
Gardens without an area should already have been allocated a
min_zoomof 16.Connects to #1636.