Merged
Conversation
Push down min_zoom on some POIs with no names (PONIs).
nvkelso
reviewed
Dec 13, 2018
| not: | ||
| fee: ['no', 'Free', 'free', '0', 'No', 'none'] | ||
| then: true | ||
| # TODO tests expect this to be false and not omitted, is that what we want? |
Member
There was a problem hiding this comment.
yes - oh, this is copy-paste of old TODO, let's just remove it
nvkelso
reviewed
Dec 13, 2018
| # higher zoom. | ||
| - filter: | ||
| leisure: pitch | ||
| sport: [baseball, basketball, football, hockey, soccer, tennis] |
Member
There was a problem hiding this comment.
The kind_detail were only listed in the example because that's what we have icons for... but I don't think that needs to be limited in the data like this. I'd remove this line and change the comment above.
Member
Author
There was a problem hiding this comment.
OK, removed the filter and adjusted tests in 5265c9d.
nvkelso
approved these changes
Dec 13, 2018
Member
nvkelso
left a comment
There was a problem hiding this comment.
One modification for https://github.com/tilezen/vector-datasource/pull/1727/files#r241259829 and then good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push down min_zoom on some POIs with no names (PONIs).
min_zoomto 17 if there's no name and the sport is whitelisted.min_zoomto 18 if there's no name.min_zoomto 18 if there's no name.min_zoom18 - pretty sure these don't usually get named.Connects to #1638.