Skip to content

Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse#1709

Merged
nvkelso merged 4 commits intotilezen:masterfrom
musculman:master
Dec 6, 2018
Merged

Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse#1709
nvkelso merged 4 commits intotilezen:masterfrom
musculman:master

Conversation

@musculman
Copy link
Copy Markdown
Contributor

@musculman musculman commented Nov 20, 2018

Connects with #1553 to document heavy good vehicle (truck) properties [edits by @nvkelso]

@nvkelso nvkelso self-requested a review November 27, 2018 06:02
Comment thread docs/layers.md Outdated
#### Roads hgv `kind_detail` values

For `hgv`the `kind_detail` values are `no`, `designated`, `destination`, `delivery`, `local` and `agricultural`.
For `hgv_restriction` the `kind_detail` values are `weight`, `height`, `length`, `width`, `wpa` (weight per axle), `kpra` (king pin to rear axle leght, in cm.), `hazmat`, `other` and `multiple` if more than one.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since people always ask, let's specify units as (kg) and (m) next to each value, please...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will post an update with it

Comment thread docs/layers.md Outdated

#### Roads hgv `kind_detail` values

For `hgv_restriction` the `kind_detail` values are `weight`, `height`, `length`, `width`, `wpa` (weight per axle), `kpra` (king pin to rear axle leght, in cm.), `hazmat`, `other` and `multiple` if more than one.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about including units, please.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do as well

Comment thread docs/layers.md Outdated
* `dog_park`
* `embankment` - A raised area of land, usually to carry a road or railway.
* `enclosure`
* `environmental_zone` - An area beloging to a protected environmental area, such as the (London Loz Emission Zone)[https://en.wikipedia.org/wiki/London_low_emission_zone].
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a better term for this like restricted_driving_zone?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that, as in general these zones are either low_emission_zone or zero_emission_zone see here.
That is why we opted for environmental_zone as more neutral as it is an area with environmental restrictions, but I get the point that perhaps it is not descriptive enough.
Should we just go with low_emission_zone as in OSM?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's go with OSM's low_emission_zone terminology.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, this is the term I used in my updated commit :)

Comment thread docs/layers.md Outdated
* `distance`: ski pistes from OpenStreetMap
* `embankment`: If the road or railway is on an embankment the value will be one of `yes`, `left` or `right` depending on whether the embankment is on both sides, the left side or the right side, respectively.
* `hgv`: optional property indicating general truck heavy goods vehicle truck access. See below for `kind_detail` list.
* `hgv_restriction`: optional property indicating limitations to heavy goods vehicle truck access. See below for `kind_detail` list.
Copy link
Copy Markdown
Member

@nvkelso nvkelso Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include here (and not below):

  • hgv_restriction_shield_text - optional property for hgv_restriction kind points with values like 5.1m. Because the units are different per restriction an abbreviation should be provided. Values in meters can be specified with one decimal precision (but value of 5.0m should be given as 5m).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why here? I put it below with the other point feature description. Because we have a set of values for the lines and another set for the points. Or would you rather have all defined together? So, merging the section " Road transportation kind values (points):" into this one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your last commits from today now I see what you meant by this comment :)
I thought it was more clear to have it separated, but I am obviously fine to have it together with the additional clarification you added as "this is also for points" and such.
All clear.

@nvkelso
Copy link
Copy Markdown
Member

nvkelso commented Nov 27, 2018

Had a quick look now, will have a deeper look Tuesday with a fresh set of eyes...

@nvkelso nvkelso changed the title Based on the discussion on tilezen#1553, here is the first version of hgv properties and environmental_zone Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse Dec 5, 2018
@nvkelso
Copy link
Copy Markdown
Member

nvkelso commented Dec 6, 2018

@musculman Please take one last look with my edits today before we merge. Thanks for your contribution to Tilezen!

@nvkelso nvkelso changed the title Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse HOLD: Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse Dec 6, 2018
@nvkelso nvkelso mentioned this pull request Dec 6, 2018
10 tasks
@musculman
Copy link
Copy Markdown
Contributor Author

@musculman Please take one last look with my edits today before we merge. Thanks for your contribution to Tilezen!

All fine from my side!

@nvkelso nvkelso changed the title HOLD: Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse Adds hgv (heavey good vehicle) roads properties and related environmental_zone landuse Dec 6, 2018
@nvkelso
Copy link
Copy Markdown
Member

nvkelso commented Dec 6, 2018

🎉

@nvkelso nvkelso merged commit b3af261 into tilezen:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants