Fix angle calculation at 180 degrees#1706
Merged
zerebubuth merged 3 commits intomasterfrom Nov 16, 2018
Merged
Conversation
The angle calculation is used to tell whether two roads are suitable for merging, and at this point we don't care about directionality (i.e: whether a horizontal road is heading left or right - it's horizontal is all we care about).
…ess until zoom < 15.
nvkelso
approved these changes
Nov 16, 2018
rmarianski
reviewed
Nov 16, 2018
Member
rmarianski
left a comment
There was a problem hiding this comment.
Whoops, I missed this earlier. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The angle calculation is used to tell whether two roads are suitable for merging, and at this point we don't care about directionality (i.e: whether a horizontal road is heading left or right - it's horizontal is all we care about).
Also, don't merge across junctions at zoom 15 - we still care about onewayness until zoom < 15.