Don't include buffered land at zooms it's not used in#1699
Merged
zerebubuth merged 1 commit intomasterfrom Oct 31, 2018
Merged
Conversation
…would be superfluous to include buffered land before that. As it turns out, this meant we were including the buffered land polygons in the output tiles at all lower zooms.
Member
|
LGTM but don't we drop buffered land completely in a later transform? Like it should never export in any zoom tiles? |
nvkelso
approved these changes
Oct 31, 2018
Member
Author
That's the case with the admin areas that we use for country code assignment, but sadly not the case for the buffered land. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin boundaries processing only starts at zoom 8, so at best it would be superfluous to include buffered land before that. As it turns out, this meant we were including the buffered land polygons in the output tiles at all lower zooms.
This drastically reduces the size of the boundaries layer for low zoom tiles: