Use the NE min zoom to cull places at low zooms.#1693
Merged
zerebubuth merged 1 commit intomasterfrom Oct 26, 2018
Merged
Conversation
…g the NE min zoom as the min_zoom property, but had failed to actually act on that by removing items outside of the zoom range.
Member
Author
Member
Member
|
Also, your zoom 2 looks pretty weird!? |
Member
|
The likely reason you're not seeing Canada region labels at zoom 3 is they are set to 3.5 and Tangram only does the evaluation at zoom 3 (and 3.5 !< 3 so it filters them out). Or your PR / existing code filters them. Looks like this PR is doing the right thing (nominal zoom + 1), so might be in the setting of min_zoom, please ensure that's taken from Natural Earth's |
Member
Author
nvkelso
approved these changes
Oct 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





We were already using the NE min zoom as the min_zoom property, but had failed to actually act on that by removing items outside of the zoom range.
Overall file size reduction (NOTE: most of the very low zoom labels come from the
earthlayer - things like continent labels):Zoom 0
It's all continent and ocean labels, no places visible.
Zoom 1
It's all continent and ocean labels, no places visible.
Zoom 2
I was expecting some places to be visible at this zoom level, as some are present in the tiles. Perhaps the label collision prevents any from appearing?
Zoom 3
Looks like a pretty good selection of capitals, major cities and country labels.
Zoom 4
Nice overview of US states and major cities. Do we have the same state data for Canada - given that we show the state borders, it might be nice to label them too? Perhaps a ☔ issue?