Add route modifier information to network.#1460
Merged
zerebubuth merged 5 commits intomasterfrom Dec 18, 2017
Merged
Conversation
rmarianski
approved these changes
Dec 18, 2017
nvkelso
requested changes
Dec 18, 2017
| * `ref`: Commonly-used reference for roads, for example "I 90" for Interstate 90. To use with shields, see `network` and `shield_text`. Related, see `symbol` for pistes. | ||
| * `all_networks` and `all_shield_texts`: All the networks of which this road is a part, and all of the shield texts. See `network` and `shield_text` below. **Note** that these properties will not be present on MVT format tiles, as we cannot currently encode lists as values. | ||
| * `network`: eg: `US:I` for the United States Interstate network, useful for shields and road selections. This only contains _road_ network types. Please see `bicycle_network` and `walking_network` for bicycle and walking networks, respectively. | ||
| * `network`: eg: `US:I` for the United States Interstate network, useful for shields and road selections. This only contains _road_ network types. Please see `bicycle_network` and `walking_network` for bicycle and walking networks, respectively. Note that networks may include "modifier" information, for example `US:I:Business` for a business route or `US:I:Truck` for a truck route. |
Member
There was a problem hiding this comment.
Since we're whitelisting those in code instead of pass-thru, let's list the values in alphabetical order here (reorder from the SQL below):
('Business', 'Spur', 'Truck', 'Alternate', 'Bypass', 'Connector', 'Historic', 'Toll', 'Scenic')
Member
There was a problem hiding this comment.
(Noting here there isn't a good OSM Wiki page for modifier to link to, so quoting it alone suffices.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
modifierinformation tonetworkproperty. For example, a route withmodifier=Businessandnetwork=US:Iwould result in an output network property ofUS:I:Business.Connects to #1387.