Skip to content

Add min_zoom = 17 for generated address points#2032

Merged
tgrigsby-sc merged 2 commits intomasterfrom
nvkelso/2023-address-point-min_zooms
Dec 15, 2021
Merged

Add min_zoom = 17 for generated address points#2032
tgrigsby-sc merged 2 commits intomasterfrom
nvkelso/2023-address-point-min_zooms

Conversation

@nvkelso
Copy link
Copy Markdown
Member

@nvkelso nvkelso commented Dec 9, 2021

Connects with #2023.

  • Update tests
  • Update docs just a bug fix

@nvkelso
Copy link
Copy Markdown
Member Author

nvkelso commented Dec 15, 2021

Relates to tilezen/tilequeue#402 which removes overstuffed features from tiles when their min_zoom is larger than the tile's nominal zoom. But if the min_zoom is null then they aren't pruned! This sets the min_zoom to 17 so the generated address points will get pruned.

@nvkelso
Copy link
Copy Markdown
Member Author

nvkelso commented Dec 15, 2021

LGTM

I'm the author so I can't approve, @travisgrigsby you want to do those honors?

Copy link
Copy Markdown
Contributor

@tgrigsby-sc tgrigsby-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the best test code I've ever witnessed in all my years of witnessing test code

@tgrigsby-sc tgrigsby-sc merged commit 4264b79 into master Dec 15, 2021
@peitili peitili deleted the nvkelso/2023-address-point-min_zooms branch December 16, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants